RFR: 8366101: Replace the use of ThreadTracker with ScopedValue in java.util.jar.JarFile [v2]
Volkan Yazici
vyazici at openjdk.org
Tue Dec 2 19:40:04 UTC 2025
On Tue, 2 Dec 2025 16:56:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which removes the usage of `jdk.internal.misc.ThreadTracker` from the `java.util.jar.JarFile` code? This addresses https://bugs.openjdk.org/browse/JDK-8366101.
>>
>> The updated code replaces the usage of `ThreadTracker` with the standard `ScopedValue` API.
>>
>> No new tests have been introduced, given the nature of the change. tier testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> use Runnable() instead of CallableOp
Marked as reviewed by vyazici (Committer).
src/java.base/share/classes/java/util/jar/JarFile.java line 1047:
> 1045: jvInitialized = true;
> 1046: }
> 1047: });
You can consider shortening this using a lambda:
ScopedValue.where(IN_VERIFIER_INIT, true).run(() -> {
initializeVerifier();
jvInitialized = true;
});
-------------
PR Review: https://git.openjdk.org/jdk/pull/28609#pullrequestreview-3531826580
PR Review Comment: https://git.openjdk.org/jdk/pull/28609#discussion_r2582559476
More information about the security-dev
mailing list