RFR: 8314323: Implement JEP 527: TLS 1.3 Hybrid Key Exchange [v9]

Wed Dec 3 09:21:21 UTC 2025

On Mon, 1 Dec 2025 21:51:43 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/KEMKeyExchange.java line 28:
>> 
>>> 26: 
>>> 27: import java.io.IOException;
>>> 28: import java.security.*;
>> 
>> Probably clearer not to use wildcard imports so we can see all the classes needed, same comment on line 32.
>
> I vaguely remember somewhere the guidance that if there are <= 5 imports, you should list them, otherwise use the wildcard.

Added the imports. (There are more than 5 though).

>> test/jdk/javax/net/ssl/TLSv13/HRRKeyShares.java line 33:
>> 
>>> 31:  * @summary Use two key share entries
>>> 32:  * @library /test/lib
>>> 33:  * @run main/othervm -Djdk.tls.namedGroups=x25519,secp256r1,secp384r1,X25519MLKEM768,SecP256r1MLKEM768,SecP384r1MLKEM1024 HRRKeyShares
>> 
>> Long line, break up into multiple lines.
>
> I noted quite a few <= 80 comments throughout, so fully agree here!  ;)

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2584266809
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2584261252