RFR: 8371333: Optimize static initialization of SSLContextImpl classes and improve logging [v2]
Sean Coffey
coffeys at openjdk.org
Wed Dec 3 12:50:21 UTC 2025
On Wed, 26 Nov 2025 17:39:01 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:
>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Move wrapText method to Utilities
>> - Merge branch 'master' into 8371333-ssl-debug
>> - use LINE_SEP
>> - 8371333
>
> src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java line 515:
>
>> 513: }
>> 514:
>> 515: public static String wrapText(String text, int maxWidth) {
>
> This seems like it might be useful outside of `SSLContext`. Do you think it could be part of `SSLLogger` rather than here? Given that it's static and visible it can stay where it is, but if other classes within SunJSSE could benefit from it it feels more natural to belong to the logger class.
Thanks for the suggestion. I see the Utilities class in same directory has a bunch of helper methods. I've moved the wrapText method in there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28511#discussion_r2584972382
More information about the security-dev
mailing list