RFR: 8369950: TLS connection to IPv6 address fails with BCJSSE due to IllegalArgumentException [v5]

Sergey Chernyshev schernyshev at openjdk.org
Wed Dec 3 15:44:25 UTC 2025


On Wed, 3 Dec 2025 08:44:05 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test that ipv4 literals do not propagate to the server names list
>
> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 136:
> 
>> 134:          */
>> 135:         conn.setSSLSocketFactory(wrapSocketFactory(sf,
>> 136:                 sslSocket -> clientSSLSocket = sslSocket));
> 
> Shall we first assert that `clientSSLSocket == null` before assignment?

The method `doClientSide()` is called from constructor, the `clientSSLSocket` is non-static and was set to `null`. Therefore, it's the only assignment of clientSSLSocket per instance. Or do you mean the check must be in the the lambda-expr?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2585626177


More information about the security-dev mailing list