RFR: 8314323: Implement JEP 527: TLS 1.3 Hybrid Key Exchange [v9]

Sean Mullan mullan at openjdk.org
Wed Dec 3 22:20:25 UTC 2025


On Wed, 3 Dec 2025 09:16:48 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java line 599:
>> 
>>> 597:                                 xp.setKey(encaped.key());
>>> 598:                                 keyShare = new KeyShareEntry(ng.id,
>>> 599:                                         encaped.encapsulation());
>> 
>> Should there be a break after this line?
>
> No, we have a break at line #606 for this.

But at this point we have created a KeyShare, why continue further through the loop?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2586793081


More information about the security-dev mailing list