RFR: 8369950: TLS connection to IPv6 address fails with BCJSSE due to IllegalArgumentException [v5]

Sergey Chernyshev schernyshev at openjdk.org
Thu Dec 4 14:06:24 UTC 2025


On Wed, 3 Dec 2025 19:53:22 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> The method `doClientSide()` is called from constructor, the `clientSSLSocket` is non-static and was set to `null`. Therefore, it's the only assignment of clientSSLSocket per instance. Or do you mean the check must be in the the lambda-expr?
>
> I mean something like:
> 
> Suggestion:
> 
>                 sslSocket -> {
>                     assertNull(clientSSLSocket);
>                     clientSSLSocket = sslSocket;
>                 }));
> 
> 
> To avoid double-assignment and eventually causing verification of the wrong value.

I made `assertEquals` instead, otherwise it shows an incorrect message - it prints the left hand operand as "expected" value, which in the case of `assertNull` is in the right hand operand.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2589205237


More information about the security-dev mailing list