RFR: 8314323: Implement JEP 527: TLS 1.3 Hybrid Key Exchange [v19]

Hai-May Chao hchao at openjdk.org
Tue Dec 9 06:22:30 UTC 2025


On Tue, 9 Dec 2025 02:07:25 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove len check from encapsulate
>
> src/java.base/share/classes/sun/security/ssl/Hybrid.java line 385:
> 
>> 383:     }
>> 384: 
>> 385:     public record SecretKeyImpl(SecretKey k1, SecretKey k2)
> 
> I mentioned this earlier as part of a general comment.  Several got addressed, but these got missed.  I think the `PublicKeys`/`PrivateKey`/`SecretKey` here could all be package private (can't be private, as they are used in a couple other classes).

Fixed. SecreyKeyImpl and PublicKeyImpl: package-private, and PrivateKeyImpl: private.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2601248138


More information about the security-dev mailing list