RFR: 8366807: JNI exception pending in Java_sun_security_pkcs11_wrapper_PKCS11_initializeLibrary of p11_general.c:106
Valerie Peng
valeriep at openjdk.org
Mon Dec 22 23:50:51 UTC 2025
On Fri, 12 Dec 2025 18:46:52 GMT, Koushik Muthukrishnan Thirupattur <duke at openjdk.org> wrote:
> The method createLockObject will return NULL if any exception is thrown, but there is no NULL verification in p11_general.c after the following line is invoked
> notifyListLock = createLockObject(env);
>
> There may be a pending exception when invoking prefetchFields(env, thisClass);
>
> So adding exception check to return immediately and do not call any further JNI functions when there is exception pending.
Change looks good.
I changed the `noreg-trivial` label to `noreg-hard` label since the latter matches better with the reason of no regression test.
-------------
Marked as reviewed by valeriep (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28799#pullrequestreview-3606093329
More information about the security-dev
mailing list