RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

Daniel Fuchs dfuchs at openjdk.org
Wed Feb 5 12:06:10 UTC 2025


On Wed, 5 Feb 2025 11:59:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 672:
> 
>> 670:      *     // Also, encode a two byte RFC 8701 GREASE ALPN value
>> 671:      *     //     e.g. 0x0A, 0x1A, 0x2A...0xFA
>> 672:      *     String rfc8701Grease8A = "\u005cu008A\u005cu008A";
> 
> jshell> String rfc8701Grease8A = "\u005cu008A\u005cu008A";
> |  Error:
> |  illegal escape character
> |  String rfc8701Grease8A = "\u005cu008A\u005cu008A";
> |                                  ^
> |  Error:
> |  illegal escape character
> |  String rfc8701Grease8A = "\u005cu008A\u005cu008A";
> |                                             ^

Is this a rendering issue or is there something missing (or superfluous) in these strings?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23379#discussion_r1942751535


More information about the security-dev mailing list