RFR: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
Weijun Wang
weijun at openjdk.org
Wed Feb 5 15:56:10 UTC 2025
On Wed, 5 Feb 2025 12:53:09 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:
> When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java
>
>
> Two warning are shown:
>
>
> test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] possible 'this' escape before subclass is fully initialized
> setHandler(handler);
>
> - setHandler is called in the constructor and a subclass may override it. It is fixed by making the method 'final'
>
>
> test/lib/security/timestamp/TsaServer.java:42: warning: [try] auto-closeable resource TsaServer has a member method close() that could throw InterruptedException
>
> - Remove `throws Exception` from TsaServer.close()
Marked as reviewed by weijun (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/23463#pullrequestreview-2596243328
More information about the security-dev
mailing list