RFR: 8349400: Improve startup speed via eliminating nested classes

Roger Riggs rriggs at openjdk.org
Mon Feb 10 15:08:16 UTC 2025


On Sat, 8 Feb 2025 08:44:04 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> You could define the static field on another class, like SecurityConstants, and then use it in the enum constructor.
>
> Creating a new empty string array every time is the original behavior, which has nothing to do with the purpose of this PR. Should we follow the principle of minimal changes? If we want to change it, we should submit another PR

Fine either way, its a fuzzy cutoff between an incidental improvement (also perf related) with the same reviewers or a new PR with a new set of emails and reviewers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23411#discussion_r1949275626


More information about the security-dev mailing list