RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v2]

Weijun Wang weijun at openjdk.org
Tue Feb 11 13:35:11 UTC 2025


On Tue, 11 Feb 2025 11:29:59 GMT, Mikhail Yankelevich <duke at openjdk.org> wrote:

>> Refactored the runNameEquals.sh to java test
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor cleanup

test/jdk/sun/security/krb5/Krb5NameEquals.java line 104:

> 102:                 result.shouldHaveExitValue(0);
> 103:             }
> 104:         } else {

Both the Java provider and the native provider need to be tested. This is not an `else`.

test/jdk/sun/security/krb5/Krb5NameEquals.java line 111:

> 109:             };
> 110: 
> 111:             final var result = ProcessTools.executeTestJava(testCommand);

There is no need to run this in a sub-process. Consider creating an individual `@run main/othervm` with the system properties is probably enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23542#discussion_r1950859905
PR Review Comment: https://git.openjdk.org/jdk/pull/23542#discussion_r1950862122


More information about the security-dev mailing list