RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

Rajan Halade rhalade at openjdk.org
Wed Feb 12 19:22:11 UTC 2025


On Wed, 12 Feb 2025 18:07:48 GMT, Mikhail Yankelevich <duke at openjdk.org> wrote:

>> Moved the sh file logic to jtreg java test.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed the year

Changes requested by rhalade (Reviewer).

test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63:

> 61:     private static void copyDbFiles() throws IOException {
> 62:         final var testFolder = System.getProperty("test.src", ".");
> 63:         final var destination = Paths.get(testFolder);

Don't update `test.src` with a copy of these files. It should instead use `test.classes`

-------------

PR Review: https://git.openjdk.org/jdk/pull/23590#pullrequestreview-2612967785
PR Review Comment: https://git.openjdk.org/jdk/pull/23590#discussion_r1953262324


More information about the security-dev mailing list