RFR: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir
Jamil Nimeh
jnimeh at openjdk.org
Tue Feb 18 19:22:36 UTC 2025
On Mon, 17 Feb 2025 18:52:17 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:
>> The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not modify the JDK home directory under test as that could impact the results of other tests, or it could fail if the JDK home dir is read-only.
>>
>> This PR updates the test to
>>
>> - clone the tested JDK into the scratch directory.
>> - create the required directory and file in the cloned JDK directory.
>> - run a subprocess using the temporal JDK to test the scenario.
>>
>> There is no need to explicitly remove the tests files with an 'after' step, as JTreg will handle cleaning the scratch directory
>
> Hi, please a review is needed.
@fguallini I'm looking it over now.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23202#issuecomment-2666349815
More information about the security-dev
mailing list