RFR: 8348309: MultiNST tests need more debugging and timing

Anthony Scarpino ascarpino at openjdk.org
Tue Feb 18 19:44:58 UTC 2025


On Tue, 18 Feb 2025 15:38:50 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> I need a review of this change that adds new timing controls for the initial server setup.  On rare occasions, more so on certain architectures, the server may not fully start before the client tries to connect.  Additional debugging is added to help identify if there are other timing issues.
>> 
>> Thanks
>> 
>> Tony
>
> test/jdk/javax/net/ssl/templates/TLSBase.java line 204:
> 
>> 202:                     write(sock, read(sock));
>> 203:                 } catch (Exception e) {
>> 204:                     System.err.println("Caught " + e.getMessage());
> 
> `e.printStackTrace()` will include the exception message. Do we need this line at all?

true

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23407#discussion_r1960479084


More information about the security-dev mailing list