RFR: 8325766: Review seclibs tests for cert expiry [v2]

[Matthew Donovan]

On Thu, 20 Feb 2025 11:22:41 GMT, Mikhail Yankelevich <duke at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed boolean array initialization
>
> test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java line 35:
> 
>> 33:  * @run main/othervm IPIdentities
>> 34:  * @author Xuelei Fan
>> 35:  */
> 
> I think you might be missing ` * @modules java.base/sun.security.x509 java.base/sun.security.util` here

I added those modules in a TEST.properties file so I wouldn't have to update every test in the directory when I get to them.

> test/lib/jdk/test/lib/security/CertificateBuilder.java line 113:
> 
>> 111:         SecureRandom random = new SecureRandom();
>> 112: 
>> 113:         boolean [] keyUsage = new boolean[]{false, false, false,
> 
> Wouldn't it be easier to just use `var keyUsage = new boolean[KeyUsage.values().length]`?

I updated the array initialization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23700#discussion_r1963507036
PR Review Comment: https://git.openjdk.org/jdk/pull/23700#discussion_r1963506494