RFR: 8349533: Refactor validator tests shell files to java [v4]

Weijun Wang weijun at openjdk.org
Mon Feb 24 19:49:59 UTC 2025


On Mon, 24 Feb 2025 17:24:51 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   othervm rm
>
> test/jdk/sun/security/validator/CertReplace.java line 205:
> 
>> 203: 
>> 204:         KeyStore ks = KeyStore.getInstance("JKS");
>> 205:         ks.load(new FileInputStream(args[0]), "changeit".toCharArray());
> 
> You've defined `PASSWORD_CHAR_ARR` for this char array.
> 
> Also, close this `FileInputStream` to be safe, and the one in `createPath` method below.

The opened input stream in the `createPath` method is still not closed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23727#discussion_r1968323409


More information about the security-dev mailing list