RFR: 8189441: Define algorithm names for keys derived from KeyAgreement [v2]

Weijun Wang weijun at openjdk.org
Fri Jan 3 16:20:35 UTC 2025


On Fri, 3 Jan 2025 13:41:05 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add key size adjustment clarification
>
> src/java.base/share/classes/javax/crypto/KeyAgreement.java line 662:
> 
>> 660:      * subsequent operations.
>> 661:      *
>> 662:      * @param algorithm the requested secret-key algorithm. This is
> 
> Did you consider instead referencing the new section you are adding for standard key algorithm names (https://bugs.openjdk.org/browse/JDK-8346736)? It could be reworded as:
> 
> "See the Key Algorithms section in the Java Security Standard Algorithm Names Specification for information about standard secret key algorithm names. Use "Generic" ..."

Good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22650#discussion_r1901946758


More information about the security-dev mailing list