RFR: 8346736: Java Security Standard Algorithm Names spec should include key algorithm names [v2]
Sean Mullan
mullan at openjdk.org
Wed Jan 8 15:31:41 UTC 2025
On Mon, 6 Jan 2025 19:11:12 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Add links to the new Key Algorithms section in the Java Security Standard Algorithm Names Specification.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> add spec links
A few more minor comments.
src/java.base/share/classes/java/security/spec/X509EncodedKeySpec.java line 76:
> 74: * encoded according to the X.509 standard. The contents of the
> 75: * array are copied to protect against subsequent modification.
> 76: * @param algorithm the algorithm name of the encoded public key
Add period to end of sentence.
src/java.base/share/classes/javax/crypto/KEM.java line 360:
> 358: * Java Security Standard Algorithm Names Specification</a>
> 359: * for information about standard secret key algorithm names.
> 360: * Use "Generic" if the output will be used as the input keying
s/Use/Specify/
src/java.base/share/classes/javax/crypto/KEMSpi.java line 203:
> 201: * Java Security Standard Algorithm Names Specification</a>
> 202: * for information about standard secret key algorithm names.
> 203: * Use "Generic" if the output will be used as the input keying
s/Use/Specify/
-------------
PR Review: https://git.openjdk.org/jdk/pull/22929#pullrequestreview-2537380221
PR Review Comment: https://git.openjdk.org/jdk/pull/22929#discussion_r1907317710
PR Review Comment: https://git.openjdk.org/jdk/pull/22929#discussion_r1907333783
PR Review Comment: https://git.openjdk.org/jdk/pull/22929#discussion_r1907336110
More information about the security-dev
mailing list