RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]
Weijun Wang
weijun at openjdk.org
Fri Jan 10 16:13:14 UTC 2025
On Fri, 10 Jan 2025 14:36:11 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> one missing year change
>
> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2068:
>
>> 2066: * Returns the full display name of the given key object. Could be
>> 2067: * - "X25519", if its getParams() is NamedParameterSpec
>> 2068: * - "EC (secp256r1)", if it's an EC key
>
> Is this true if it is a 3rd-party provider? `NamedCurve` is an internal class.
Good catch. I've fixed it by using `CurveDB.lookup` to recognize the params. I've manually run `keytool.Main` after `Security.insertProviderAt(bc, 1)` and can see the difference after the code change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22735#discussion_r1910594677
More information about the security-dev
mailing list