RFR: 8347596: Update HSS/LMS public key encoding [v2]

[Mark Powers]

On Mon, 13 Jan 2025 18:26:17 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Update the encoding of HSS/LMS public key to be consistent with https://www.rfc-editor.org/rfc/rfc9708.html#name-changes-since-rfc-8708 and https://datatracker.ietf.org/doc/html/draft-ietf-lamps-x509-shbs-13#name-hss-public-keys.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove the wrapping in a helper method

Does this interoperate with BC?

src/java.base/share/classes/sun/security/provider/HSS.java line 782:

> 780:         protected void parseKeyBits() throws InvalidKeyException {
> 781:             byte[] keyArray = getKey().toByteArray();
> 782:             // Check less than minimum length to make sure this method works as expected

s/Check less/Check if less/

or just delete the comment since it adds no useful information

src/java.base/share/classes/sun/security/provider/HSS.java line 788:

> 786:             if (keyArray[0] == DerValue.tag_OctetString
> 787:                     && keyArray[1] == keyArray.length - 2) {
> 788:                 // pre-8347596 format that has an inner OCTET STRING.

I think I would delete the "pre-8347596 format" part of the comment.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23083#pullrequestreview-2548097172
PR Review Comment: https://git.openjdk.org/jdk/pull/23083#discussion_r1913890768
PR Review Comment: https://git.openjdk.org/jdk/pull/23083#discussion_r1913899538