RFR: 8347596: Update HSS/LMS public key encoding [v2]

Mark Powers mpowers at openjdk.org
Tue Jan 14 00:21:38 UTC 2025


On Mon, 13 Jan 2025 23:42:27 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/provider/HSS.java line 788:
>> 
>>> 786:             if (keyArray[0] == DerValue.tag_OctetString
>>> 787:                     && keyArray[1] == keyArray.length - 2) {
>>> 788:                 // pre-8347596 format that has an inner OCTET STRING.
>> 
>> I think I would delete the "pre-8347596 format" part of the comment.
>
> Why? Curious people can further check out what happened from here.

Maybe it's a Solaris thing where bug IDs in the code was frowned upon.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23083#discussion_r1913940466


More information about the security-dev mailing list