RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v11]

Kevin Driver kdriver at openjdk.org
Fri Jan 17 19:39:42 UTC 2025


On Fri, 17 Jan 2025 19:35:59 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve TestContext note about expectedOpOut
>>   
>>   Co-authored-by: Martin Balao Alonso <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java line 198:
> 
>> 196:                 CK_ATTRIBUTE.SIGN_TRUE};
>> 197: 
>> 198:         P12MacPBEKeyInfo(String algo, long kdfMech, HMACKeyInfo hmacKi) {
> 
> Maybe I'm missing something. Why this change? At least on the software side, we're leaving PBE algs untouched.

Just making use of newer classes, I suppose.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1920661057


More information about the security-dev mailing list