RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

Martin Balao mbalao at openjdk.org
Tue Jan 21 18:54:42 UTC 2025


On Tue, 21 Jan 2025 18:13:04 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test case with empty inputs
>>   
>>   Co-authored-by: Martin Balao Alonso <mbalao at redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>
> Thank you for discussion and updates made. I approve.

Thanks for your review, @driverkt 

@driverkt , @wangweij May I ask you to formally approve the PR?

@valeriepeng , May I ask you to re-approve the PR? (as there were changes after your review)

@seanjmullan , should I move CSR [JDK-8344464](https://bugs.openjdk.org/browse/JDK-8344464) to finalized? Can we have CSR [JDK-8346721](https://bugs.openjdk.org/browse/JDK-8346721) reviewed?

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22215#issuecomment-2605500823


More information about the security-dev mailing list