RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v7]

Mikhail Yankelevich duke at openjdk.org
Fri Jan 24 17:05:07 UTC 2025


On Thu, 23 Jan 2025 15:59:13 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typos
>
> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line 55:
> 
>> 53:         PasswordCallback nc2 = new PasswordCallback("Visible: ", true);
>> 54:         System.out.println("Two passwords will be prompted for. The first one " +
>> 55:                 "should have echo off, the second one on. Otherwise, this test fails");
> 
> After “will be prompted for”, add a phrase like “enter something at each prompt and press Enter/Return.” This ensures users don’t simply press Enter and end up seeing nothing. You can also add a blank line after this to make the paragraph stand out more.

done in the next commit

> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line 72:
> 
>> 70: 
>> 71:             boolean testFailed = new Password().validate(
>> 72:                     "Please copy and execute the following script in the terminal/cmd, " +
> 
> "the terminal/cmd" -> "a terminal/cmd window".

done in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1928991086
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1928990839


More information about the security-dev mailing list