RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]
Daniel Jeliński
djelinski at openjdk.org
Tue Jul 1 07:34:06 UTC 2025
On Thu, 26 Jun 2025 17:34:45 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java with -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too
>> - retry the ResetControlStream test as needed
>> - http3: fix pending connection and reconnection on stream limit reached logic
>> - http3: pending acknowledgement should be registered before actually sending the packet
>> - http3: fix race with ping requests in PacketSpaceManager.java causing intermittent failures in H3ErrorHandlingTest.java
>> - http3: improve exceptions in Http3ServerExchange.java
>> - http3: fix exception handling in CancelRequestTest.java
>> - http3: review feedback - revert HPACK.java
>> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC
>> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215
>
> src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java line 49:
>
>> 47: static final ExtensionConsumer chOnLoadConsumer =
>> 48: new CHKeyShareConsumer();
>> 49: static final HandshakeAbsence chOnTradeAbsence =
>
> Could we fix that one in mainline to remove this file from the PR?
[JDK-8361125](https://bugs.openjdk.org/browse/JDK-8361125)
> src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java line 61:
>
>> 59: static final HandshakeConsumer chOnTradeConsumer =
>> 60: new CHPreSharedKeyUpdate();
>> 61: static final HandshakeAbsence chOnTradeAbsence =
>
> Could we bring this change to mainline to remove this file from this PR?
[JDK-8361125](https://bugs.openjdk.org/browse/JDK-8361125)
> src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java line 50:
>
>> 48: static final ExtensionConsumer chOnLoadConsumer =
>> 49: new CHSupportedGroupsConsumer();
>> 50: static final HandshakeAbsence chOnTradeAbsence =
>
> Another one that could disappear if we fixed that typo in mainline first.
> @djelinski would you be willing to do that?
[JDK-8361125](https://bugs.openjdk.org/browse/JDK-8361125)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2176646140
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2176645611
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2176645272
More information about the security-dev
mailing list