RFR: 8315487: Security Providers Filter [v23]

[Francisco Ferrari Bihurriet]

On Fri, 6 Jun 2025 17:35:22 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 1268 commits:
>> 
>>  - 8315487: Security Providers Filter
>>    
>>    Co-authored-by: Francisco Ferrari Bihurriet <fferrari at redhat.com>
>>    Co-authored-by: Martin Balao <mbalao at redhat.com>
>>  - 8356126: Duplication handling and optimization of CaptureCallState
>>    
>>    Reviewed-by: jvernee
>>  - 8332934: Do loop with continue with subsequent switch leads to incorrect stack maps
>>    
>>    Reviewed-by: vromero
>>  - 8354461: Update tests to disable streaming output for attach tools
>>    
>>    Reviewed-by: sspitsyn, cjplummer
>>  - 8351313: VM crashes when AOTMode/AOTCache/AOTConfiguration are empty
>>    
>>    Reviewed-by: ccheung, shade, kvn
>>  - 8356318: Unexpected VerifyError in AOT training run
>>    
>>    Reviewed-by: shade, kvn
>>  - 8356025: Provide a PrintVMInfoAtExit diagnostic switch
>>    
>>    Reviewed-by: mbaesken, jsikstro
>>  - 8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled
>>    
>>    Reviewed-by: coleenp
>>  - 8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java
>>    
>>    Reviewed-by: dnsimon, yzheng
>>  - 8355775: Improve symbolic sharing in dynamic constant pool entries
>>    
>>    Reviewed-by: asotona
>>  - ... and 1258 more: https://git.openjdk.org/jdk/compare/8c09d40d...37d3f23a
>
> src/java.base/share/classes/java/security/AlgorithmParameterGenerator.java line 162:
> 
>> 160:      * {@link System#getProperty(String) System} and
>> 161:      * {@link Security#getProperty(String) Security} properties determine
>> 162:      * which services are enabled. A service that is not enabled by the
> 
> In these and other APIs, I think it would be useful to link to `java.security.Provider.Service` when mentioning "services" since this is the first mention of that term in this API.

Addressed in 59d82288d5ccc01f2d807be1638dcbc6d167b132.

> src/java.base/share/classes/java/security/Security.java line 387:
> 
>> 385:      * algorithm and provider. Search is case-insensitive.
>> 386:      */
>> 387:     private static Provider.Service findService(String type, String algo,
> 
> You need to add a similar implementation note about the `jdk.security.providers.filter` property to the `getProviders(String)` method since it can affect what providers are returned.

Addressed in c59bbeabbca16c70c7945bb80ce3e8b3ee9967c8. Please also check f3a190d6a8f0fc3a448f5a33457ef639396e9076.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15539#discussion_r2190144209
PR Review Comment: https://git.openjdk.org/jdk/pull/15539#discussion_r2190144295