RFR: 8350709: [JMH] test ProtectionDomainBench failed for 2 threads config [v2]
Mark Powers
mpowers at openjdk.org
Wed Jul 16 16:10:25 UTC 2025
On Wed, 16 Jul 2025 14:38:16 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>>
>> comments from turbanoff
>
> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 112:
>
>> 110: throws ClassNotFoundException {
>> 111: if (name.equals(state.classNames[state.index] /* "B" + index */)) {
>> 112: assert state.compiledClasses[state.index] != null;
>
> Suggestion:
>
> assert state.compiledClasses[state.index] != null;
fixed
> test/micro/org/openjdk/bench/java/security/ProtectionDomainBench.java line 135:
>
>> 133: @Benchmark
>> 134: @Fork(value = 3)
>> 135: public void noSecurityManager(MyState state) throws ClassNotFoundException {
>
> Suggestion:
>
> public void noSecurityManager(MyState state) throws ClassNotFoundException {
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26301#discussion_r2210862621
PR Review Comment: https://git.openjdk.org/jdk/pull/26301#discussion_r2210863824
More information about the security-dev
mailing list