RFR: 8343395: SSLLogger doesn't work for formatted messages [v3]

Sean Coffey coffeys at openjdk.org
Fri Jul 18 14:38:35 UTC 2025


> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug mode)
> 
> SSL Debug messages don't use format specifiers. As a result, any custom format data isn't printed. Proposed solution is to append the SSL custom format output to the original debug message. Similar approach used for `SSLConsoleLogger ` mode.
> 
> Used this opportunity to delete some old commented code and to replace use of `"\n"` with `System.lineSeparator()`
> 
> DebugPropertyValuesTest also updated to test new logic.

Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8343395-formatter
 - Text Blocks use \n by default
 - 8343395

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25934/files
  - new: https://git.openjdk.org/jdk/pull/25934/files/51eb0f1b..e42c2001

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25934&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25934&range=01-02

  Stats: 45895 lines in 1530 files changed: 26228 ins; 10462 del; 9205 mod
  Patch: https://git.openjdk.org/jdk/pull/25934.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25934/head:pull/25934

PR: https://git.openjdk.org/jdk/pull/25934


More information about the security-dev mailing list