RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Fri Jul 18 20:51:37 UTC 2025
On Wed, 16 Jul 2025 17:31:41 GMT, Rajan Halade <rhalade at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> checking for root user automatically
>
> test/jdk/sun/security/krb5/config/native/TestDynamicStore.java line 71:
>
>> 69: .awaitAndCheck();
>> 70: }
>> 71:
>
> Can the test fail here if the it is still run without sudo and `user.name` is not `root`? It could happen that executor clicks pass even when not run in sudo leading to unexpected failures which require additional triage. PASS/FAIL frame above is not needed but may be good to have as an instruction reminder.
Changing alert to `JOptionPane`, it will just ask to restart and fail
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26293#discussion_r2216897801
More information about the security-dev
mailing list