RFR: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures
Matthew Donovan
mdonovan at openjdk.org
Mon Jul 21 11:47:41 UTC 2025
On Mon, 21 Jul 2025 10:49:18 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
> When the test is run now the reason for the failure will be requested providing further feedback.
test/jdk/sun/security/tools/keytool/i18n.java line 390:
> 388: new FlowLayout(FlowLayout.CENTER,
> 389: 4,
> 390: 0));
minor nit: This might be a little more readable if the 4 and 0 were on the same line as `new FlowLayout(...`
test/jdk/sun/security/tools/keytool/i18n.java line 394:
> 392: 0,
> 393: 0,
> 394: 0));
Similar to the other comment, do you need to put these arguments on their own lines?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26412#discussion_r2218923399
PR Review Comment: https://git.openjdk.org/jdk/pull/26412#discussion_r2218954910
More information about the security-dev
mailing list