RFR: 8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags [v2]

[Rajan Halade]

On Mon, 21 Jul 2025 11:59:30 GMT, Lei Zhu <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> In the test case, `ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));`, 
>> `ProcessTools.createTestJavaProcessBuilder()` will call `Utils.prependTestJavaOpts()` method, `Utils.addTestJavaOpts()` will also call `Utils.prependTestJavaOpts()`, `Utils.prependTestJavaOpts()` method will execute the following code.
>> 
>> 
>>     public static String[] getTestJavaOpts() {
>>         List<String> opts = new ArrayList<String>();
>>         Collections.addAll(opts, safeSplitString(VM_OPTIONS));
>>         Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
>>         return opts.toArray(new String[0]);
>>     }
>> 
>> 
>> So the jvm flag will be added repeatedly here, so I removed `Utils.addTestJavaOpts()`.
>> 
>> Just removed duplicate jvm flags, no other changes, risk is low.
>
> Lei Zhu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update full name

Hi @Korov, I appreciate the initiative to have the fix for this bug, but in the future, could we coordinate beforehand if a bug is already assigned to someone else? It helps avoid duplicate work and confusion.

Have you signed the OCA to contribute to OpenJDK? Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26404#issuecomment-3097076375