Withdrawn: 8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags

Lei Zhu duke at openjdk.org
Wed Jul 23 13:49:59 UTC 2025


On Sun, 20 Jul 2025 06:30:22 GMT, Lei Zhu <duke at openjdk.org> wrote:

> Hi all,
> 
> In the test case, `ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));`, 
> `ProcessTools.createTestJavaProcessBuilder()` will call `Utils.prependTestJavaOpts()` method, `Utils.addTestJavaOpts()` will also call `Utils.prependTestJavaOpts()`, `Utils.prependTestJavaOpts()` method will execute the following code.
> 
> 
>     public static String[] getTestJavaOpts() {
>         List<String> opts = new ArrayList<String>();
>         Collections.addAll(opts, safeSplitString(VM_OPTIONS));
>         Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
>         return opts.toArray(new String[0]);
>     }
> 
> 
> So the jvm flag will be added repeatedly here, so I removed `Utils.addTestJavaOpts()`.
> 
> Just removed duplicate jvm flags, no other changes, risk is low.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/26404


More information about the security-dev mailing list