RFR: 8244336: Restrict algorithms at JCE layer [v2]

[Valerie Peng]

On Wed, 30 Jul 2025 14:56:20 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments from Sean and Tony.
>
> src/java.base/share/classes/com/sun/crypto/provider/RSACipherAdaptor.java line 48:
> 
>> 46:  *
>> 47:  * This is mostly refactored from the private static CipherAdapter class
>> 48:  * in the java.security.Signature class
> 
> This comment won't be that helpful now that the static CipherAdapter class is gone. Maybe just remove it?

Ok, I can do that.

> src/java.base/share/classes/com/sun/crypto/provider/RSACipherAdaptor.java line 50:
> 
>> 48:  * in the java.security.Signature class
>> 49:  */
>> 50: public final class RSACipherAdaptor extends SignatureSpi {
> 
> Can this be package-private?

This is the `SignatureSpi` implementation class for the `NONEwithRSA` signature, so it has to be public just like other `XXXSpi` implementation classes.

> src/java.base/share/classes/com/sun/crypto/provider/RSACipherAdaptor.java line 59:
> 
>> 57:     }
>> 58: 
>> 59:     protected void engineInitVerify(PublicKey publicKey)
> 
> Consider adding `@Override` annotations where relevant.

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244156039
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244155735
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244157603