RFR: 8350689: Turn on timestamp and thread metadata by default for java.security.debug [v4]
Sean Mullan
mullan at openjdk.org
Tue Jun 3 15:14:54 UTC 2025
On Tue, 3 Jun 2025 13:38:16 GMT, Sean Coffey <coffeys at openjdk.org> wrote:
>> Removal of the `+thread` and `+timestamp` options that were used to control the logging behavior of output from the `java.security.debug` system property.
>>
>>
>> To enhance the security debug logs, the thread and timestamp data should always be present. This brings it to a par with another important security debug system property, the TLS debug property: javax.net.debug. Output from the TLS `javax.net.debug` logs always contains thread and timestamp data.
>>
>> This patch remove the `+thread` and `+timestamp` support code and print thread and timestamp data by default. This enancement is only proposed for the JDK feature release. Update releases can continue to opt into such data.
>>
>> Debug output data from use of the `java.security.debug` property will now resemble something like the following:
>>
>>
>>
>> properties[0x10|main|Security.java:122|2025-05-01 14:59:42.859 UTC]: Initial security property: package.definition=sun.misc.,sun.reflect.
>> properties[0x10|main|Security.java:122|2025-05-01 14:59:42.859 UTC]: Initial security property: krb5.kdc.bad.policy=tryLast
>>
>>
>> I've also trimmed back on some of the test case coverage since use of `+thread` and `+timestamp` options is now redundant with this patch.
>
> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - tweak sentence in debug-system-property.html
> - Merge branch 'master' into 8350689-default-timestamps
> - Update property doc as per Sean Mullan comment
> - Incorporate review comments from Mark
> - Merge branch 'master' into 8350689-default-timestamps
> - update system property doc
> - 8350689
Marked as reviewed by mullan (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25528#pullrequestreview-2892968462
More information about the security-dev
mailing list