RFR: 8358159: Empty mode/padding in cipher transformations [v3]
Valerie Peng
valeriep at openjdk.org
Wed Jun 4 17:54:03 UTC 2025
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M <varadam at openjdk.org> wrote:
>> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding" throws NoSuchAlgorithmException.
>> This patch restores the behavior by ensuring that empty mode or padding strings are interpreted as null.
>>
>> Testing done for : tier1 - fastdebug level (AIX)
>>
>> JBS: [JDK-8358159](https://bugs.openjdk.org/browse/JDK-8358159)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>
> whitespace error fix
test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 27:
> 25: * @test
> 26: * @bug 8358159
> 27: * @summary test that the Cipher.getInstance() handles transformations with empty mode and/or padding
nit: In general, we try to keep the lines <= 80 chars. Could you try breaking lines longer than 80 chars into multiple lines? There are a few lines in this test are longer than 80 chars.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25547#discussion_r2127134802
More information about the security-dev
mailing list