RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v6]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 4 17:54:25 UTC 2025
On Wed, 4 Jun 2025 15:46:36 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>>
>> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
>> It adds a non-exposed / non-exported internal implementation of the QUIC protocol based on DatagramChannel and the SunJSSE SSLContext provider.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 495 commits:
>
> - merge latest changes from master branch
> - http3: fix bug introduced by Http3ConnectionPool and improved debug logs
> - http3: refactor HTTP/3 connection pool management in a separate class
> - Ignore DestroyFailedExceptions
> - Remove outdated TODO
> - Remove outdated TODO
> - Remove cryptic TODO
> - Remove outdated TODO
> - Fix race in test server's Http3StreamDispatcher
> - Test H3 server: close connection if control stream closed
> - ... and 485 more: https://git.openjdk.org/jdk/compare/7838321b...a41217f0
src/java.net.http/share/classes/jdk/internal/net/http/hpack/HPACK.java line 176:
> 174:
> 175: @FunctionalInterface
> 176: interface BufferUpdateConsumer {
@AlekseiEfimov It looks like this change is no longer required and could be reverted
src/java.net.http/share/classes/jdk/internal/net/http/hpack/ISO_8859_1.java line 43:
> 41: // The encoding is simple and well known: 1 byte <-> 1 char
> 42: //
> 43: final class ISO_8859_1 {
OK - this class is actually used in QPack as well as HPack. Same for the `QuickHuffman` class below (notice that this is Quick - not Quic ;-) )
It might be interesting to investigate if we could pull out these classes to a common location to break the tie between QPack and HPack. Something to think about after integration maybe.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2126966393
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2127123043
More information about the security-dev
mailing list