RFR: 8358171: Additional code coverage for PEM API [v4]
Fernando Guallini
fguallini at openjdk.org
Thu Jun 5 10:20:42 UTC 2025
On Thu, 5 Jun 2025 08:56:42 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>>
>> - comment
>> - Merge branch 'master' into 8358171
>> - add invalid PEM content test
>> - Merge branch 'master' into 8358171
>> - add logging line
>> - lines comments
>> - add final break and test comment
>> - multi thread and defaut algo tests
>> - more test coverage for PEM
>
> test/jdk/java/security/PEM/PEMMultiThreadTest.java line 47:
>
>> 45: public static void main(String[] args) throws Exception {
>> 46: PEMEncoder encoder = PEMEncoder.of();
>> 47: try(ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) {
>
> Suggestion:
>
> try (ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) {
Updated !
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25588#discussion_r2128491245
More information about the security-dev
mailing list