RFR: 8359388: Stricter checking for cipher transformations [v2]

Valerie Peng valeriep at openjdk.org
Wed Jun 18 06:22:30 UTC 2025


On Tue, 17 Jun 2025 10:21:40 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated test per Mikhail's review comments.
>
> test/jdk/javax/crypto/Cipher/TestEmptyModePadding.java line 30:
> 
>> 28:  * @summary test that the Cipher.getInstance() would reject improper
>> 29:  *     transformations with empty mode and/or padding.
>> 30:  * @run main TestEmptyModePadding
> 
> minor: Is `@run` needed here? It's fine to leave it here, if you prefer it this way though.

I am ok either way, just didn't bother to remove it from the original test. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25808#discussion_r2153738427


More information about the security-dev mailing list