RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

[Fernando Guallini]

On Wed, 5 Mar 2025 13:48:37 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   SSLContextTemplate and using asserts
>
> test/jdk/sun/security/ssl/SSLSocketImpl/NonAutoClose.java line 77:
> 
>> 75:     private final static int TLS_CLIENT_VAL = 4;
>> 76: 
>> 77:     private void expectValue(int got, int expected, String msg) throws IOException {
> 
> Can you just use the Asserts class instead?

Updated the old code with all suggestions, thanks

> test/jdk/sun/security/ssl/SSLSocketImpl/SetClientMode.java line 66:
> 
>> 64:      * Where do we find the keystores?
>> 65:      */
>> 66:     private final static String pathToStores = "../../../../javax/net/ssl/etc";
> 
> Could you use either SSLContextTemplate or SSLSocketTemplate for this test?

Sure, SSLContextTemplate is a better fit for these tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23898#discussion_r1983264318
PR Review Comment: https://git.openjdk.org/jdk/pull/23898#discussion_r1983264051