RFR: 8345940: Migrate security-related resources from Java classes to properties files [v4]

Artur Barashev abarashev at openjdk.org
Fri Mar 7 23:06:55 UTC 2025


On Fri, 7 Mar 2025 22:03:20 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update keytool and jarsigner resources location
>
> src/java.base/share/classes/sun/security/util/LocalizedMessage.java line 1:
> 
>> 1: /*
> 
> Latter copyright year on this file can be bumped.

Done.

> src/java.base/share/classes/sun/security/util/LocalizedMessage.java line 92:
> 
>> 90:      * Return a non-localized string corresponding to the provided key, and
>> 91:      * formatted with the provided arguments. All strings are obtained from
>> 92:      * sun.security.util.resources, and the formatting only supports
> 
> The method above can have the same adjustment right?

Done.

> src/java.base/share/classes/sun/security/util/ResourcesMgr.java line 1:
> 
>> 1: /*
> 
> Copyright year as well.

Done, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22774#discussion_r1985825899
PR Review Comment: https://git.openjdk.org/jdk/pull/22774#discussion_r1985825758
PR Review Comment: https://git.openjdk.org/jdk/pull/22774#discussion_r1985825650


More information about the security-dev mailing list