RFR: 8345940: Migrate security-related resources from Java classes to properties files [v4]
Artur Barashev
abarashev at openjdk.org
Mon Mar 10 14:36:05 UTC 2025
On Fri, 7 Mar 2025 21:50:53 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update keytool and jarsigner resources location
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties line 40:
>
>> 38: If.keystore.is.not.password.protected.then.storepass.and.keypass.must.not.be.specified=Wenn der Keystore nicht kennwortgeschützt ist, dürfen -storepass und -keypass nicht angegeben werden
>> 39: Usage.jarsigner.options.jar.file.alias=Verwendung: jarsigner [options] jar-file alias
>> 40: .jarsigner.verify.options.jar.file.alias.=\u0020 jarsigner -verify [options] jar-file [alias...]
>
> We have generally kept `\u0020` in these properties files for the purpose of making it clear that trailing white space in a value is intentional. Can we convert these non trailing `\u0020` to just ` `?
In properties files the whitespaces after `=` get trimmed when compiled, so when we replace `\u0020` with ` ` we get an incorrect string.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22774#discussion_r1987420604
More information about the security-dev
mailing list