RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v3]

Mikhail Yankelevich myankelevich at openjdk.org
Tue Mar 11 18:38:35 UTC 2025


On Tue, 25 Feb 2025 17:50:53 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63:
>> 
>>> 61:     private static final SunPKCS11[] providers = new SunPKCS11[NUM_PROVIDERS];
>>> 62: 
>>> 63:     private static void copyDbFiles() throws IOException {
>> 
>> We have existing utility method for this at https://github.com/openjdk/jdk/blob/a49f8332edc7da2a9494cd0dc96e5aa7271d9883/test/jdk/sun/security/pkcs11/PKCS11Test.java#L846.
>
> We are looking to refactor the PKCS11Test.java, this will be addressed then. I will hold this review until we decide the right approach.

The new commit has the test extending the PKCS11Test, so this should be changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23590#discussion_r1989921907


More information about the security-dev mailing list