RFR: 8350964: Add an ArtifactResolver.fetch(clazz) method [v2]

Weijun Wang weijun at openjdk.org
Wed Mar 12 13:36:59 UTC 2025


On Tue, 11 Mar 2025 16:24:23 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> test/jdk/sun/security/provider/acvp/Launcher.java line 181:
>> 
>>> 179:     }
>>> 180: 
>>> 181:     private static Path fetchACVPServerTests(Class<?> clazz) {
>> 
>> Is there a point in this method? It's used in 1 spot only it seems and you can just directly call `fetchOne`
>
> It encapsulates all of the logic involved in getting the tests. Specifically, what to do if the tests can't be fetched. It could be done in `main()` but this is a little cleaner.

I'd rather just let `ArtifactResolver.fetchOne` throw the `SkippedException`. Is that always what we need?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991507310


More information about the security-dev mailing list