RFR: 8350964: Add an ArtifactResolver.fetch(clazz) method [v2]

Matthew Donovan mdonovan at openjdk.org
Wed Mar 12 16:36:54 UTC 2025


On Wed, 12 Mar 2025 13:27:49 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed exception message in Artifact resolver and fixed logic in keytool test
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 718:
> 
>> 716:     }
>> 717: 
>> 718:     private static Path fetchNssLib(String osId, Path libraryName) throws IOException {
> 
> Is the `IOException` caught later and wrapped as a `SkippedException`?

I changed `ArtifactResolver.fetchOne()` to throw a SkippedException but this method still throws an IOException if the nss directory/artifact doesn't contain the necessary files. That case is handled by different tests and I didn't want to change it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991882025


More information about the security-dev mailing list