RFR: 8341775: Duplicate manifest files are removed by jarsigner after signing [v8]

Kevin Driver kdriver at openjdk.org
Thu Mar 13 16:46:49 UTC 2025


On Tue, 11 Mar 2025 21:50:56 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 1993:
> 
>> 1991:                 hasMultipleManifests = true;
>> 1992:             }
>> 1993:         }
> 
> Can we put everything above in a try-with-resources block?
> 
> Also, are you sure we only print out this warning when `verbose != null`?

I'll refactor to use try-with-resources.

It was originally described to me as a verbose message, but I don't see anything in the bug description to require it only during verbose. I've removed the check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22222#discussion_r1993927169


More information about the security-dev mailing list