RFR: 8341775: Duplicate manifest files are removed by jarsigner after signing [v11]

Hai-May Chao hchao at openjdk.org
Thu Mar 13 17:31:57 UTC 2025


On Thu, 13 Mar 2025 17:15:33 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> JDK-8341775: In the case where there is a *single* META-INF directory but potentially *multiple* manifest files of different cases, print a warning before selecting the first one and ignoring the rest (the current behavior should be maintained).
>
> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - merge master
>  - merge master
>  - code review comments
>  - code review comments
>  - review comments
>  - force-add jar
>  - re-write to make the changes in the jarsigner tool itself, rather than the API
>  - Revert "JDK-8341775: In the case where there is a *single* META-INF directory but potentially *multiple* manifest files of different cases, print a warning before selecting the first one and ignoring the rest."
>    
>    This reverts commit 06e90503f3e75b1b432ec0a196716f01ebb7344a.
>    
>    # Please enter the commit message for your changes. Lines starting
>    # with '#' will be kept; you may remove them yourself if you want to.
>    # An empty message aborts the commit.
>    #
>    # On branch 8341775
>    # Your branch is up to date with 'origin/8341775'.
>    #
>    # Changes to be committed:
>    #	modified:   src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java
>    #
>  - Merge remote-tracking branch 'origin/master' into 8341775
>    # Please enter a commit message to explain why this merge is necessary,
>    # especially if it merges an updated upstream into a topic branch.
>    #
>    # Lines starting with '#' will be ignored, and an empty message aborts
>    # the commit.
>  - Merge branch 'master' of github.com:openjdk/jdk into 8341775
>    # Please enter a commit message to explain why this merge is necessary,
>    # especially if it merges an updated upstream into a topic branch.
>    #
>    # Lines starting with '#' will be ignored, and an empty message aborts
>    # the commit.
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/771e160d...e4677965

test/jdk/sun/security/tools/jarsigner/MultiManifest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2009, 2025, Oracle and/or its affiliates. All rights reserved.

Change year to 2025

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22222#discussion_r1994007908


More information about the security-dev mailing list