RFR: 8351566: Consolidate third party artifacts used in tests

[Matthew Donovan]

On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

> 8351566: Consolidate third party artifacts used in tests

test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 44:

> 42:         final Class<?> nssLibClass = getNssLibClass(osId);
> 43:         if(nssLibClass == null){
> 44:             throw new RuntimeException("Platform not recognised"); // should never happen

instead of "not recognized" maybe "not supported"

test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 69:

> 67:     }
> 68: 
> 69:     public static String getNSSLibDir(String library) throws Exception {

You have a `getNSSLibDir()` method and one called `getNSSDirectory()`.  Please add Javadocs to explain what's what.

test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 99:

> 97:     }
> 98: 
> 99:     public static String getOsId() {

does this method and the one that returns the @Artifact class need to be public?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23988#discussion_r1991282723
PR Review Comment: https://git.openjdk.org/jdk/pull/23988#discussion_r1993610802
PR Review Comment: https://git.openjdk.org/jdk/pull/23988#discussion_r1991298843