RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings

Valerie Peng valeriep at openjdk.org
Mon Mar 24 21:02:12 UTC 2025


On Tue, 18 Mar 2025 23:35:45 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi @valeriepeng, I found code assuming `com.sun.crypto.provider.PBEKey` contains only ASCII, please find my suggestions in the review comments. I also added a suggestion for the tests, in order to increase the coverage in that regard.
> 
> All the patches are verified to cleanly apply on top of this PR branch, when copied through the GitHub's copy button and applied with `xclip -sel clip | git apply`.

Great, thanks for catching this!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24068#issuecomment-2749382215


More information about the security-dev mailing list