RFR: 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java [v2]

[Mikhail Yankelevich]

On Thu, 1 May 2025 05:00:13 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed file creation to use Utils.createTempFile
>
> test/jdk/sun/security/pkcs12/P12SecretKey.java line 68:
> 
>> 66: 
>> 67:         // temporary files are created in scratch directory
>> 68:         final File ksFile = File.createTempFile("test", ".test", new File("."));
> 
> Instead, update test to use `createTempFile` from https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/Utils.java#L815. It is designed as an replacement that doesn't leave files behind in `tmp`.

Changed in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24718#discussion_r2070133623